Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix docker-env-setup.md #1642

Merged
merged 1 commit into from
Nov 5, 2024
Merged

docs: fix docker-env-setup.md #1642

merged 1 commit into from
Nov 5, 2024

Conversation

peng-yq
Copy link
Contributor

@peng-yq peng-yq commented Oct 28, 2024

Relevant Issue (if applicable)

#1633

Details

Just fix the manual.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@peng-yq peng-yq requested a review from a team as a code owner October 28, 2024 07:41
@peng-yq peng-yq requested review from imeoer, jiangliu and gaius-qi and removed request for a team October 28, 2024 07:41
@peng-yq peng-yq mentioned this pull request Oct 28, 2024
Closed
imeoer
imeoer approved these changes Nov 1, 2024
View reviewed changes
Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@imeoer
Copy link
Collaborator

imeoer commented Nov 1, 2024

@peng-yq Let's pass the DCO check with git commit -s. :)

peng-yq
peng-yq commented Nov 4, 2024
View reviewed changes
Copy link
Contributor Author

@peng-yq peng-yq left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imeoer Already done! Sorry for my lack of skill : (.

@peng-yq peng-yq changed the title docs: fix docker-env-setup.md docs: fix docker-env-setup.md Signed-off-by: Author Name <[email protected]> Nov 4, 2024
@peng-yq peng-yq changed the title docs: fix docker-env-setup.md Signed-off-by: Author Name <[email protected]> docs: fix docker-env-setup.md Nov 4, 2024
imeoer
imeoer approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@imeoer imeoer merged commit 288497f into dragonflyoss:stable/v2.2 Nov 5, 2024
1 check passed
@imeoer
Copy link
Collaborator

imeoer commented Nov 5, 2024

@peng-yq Please also submit a PR to master branch, thanks!

@peng-yq
Copy link
Contributor Author

peng-yq commented Nov 5, 2024

@peng-yq Please also submit a PR to master branch, thanks!

Sure! I'll check the manual of the master branch.

@peng-yq
Copy link
Contributor Author

peng-yq commented Nov 5, 2024

@imeoer , Already submit a PR to the master branch #1645.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imeoer imeoer imeoer approved these changes

@jiangliu jiangliu Awaiting requested review from jiangliu jiangliu is a code owner automatically assigned from dragonflyoss/nydus-reviewers

@gaius-qi gaius-qi Awaiting requested review from gaius-qi gaius-qi is a code owner automatically assigned from dragonflyoss/nydus-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peng-yq @imeoer